Skip to content

[pre-commit.ci] pre-commit autoupdate #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pre-commit-ci wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[pre-commit.ci] pre-commit autoupdate #1431

pre-commit-ci wants to merge 2 commits into from

Conversation

@pre-commit-ci
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Nov 18, 2024 •
edited
Loading

@codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.03%. Comparing base (254edf1) to head (9d4d11e).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1431      +/-   ##
==========================================
- Coverage   96.11%   96.03%   -0.09%     
==========================================
  Files          72       72              
  Lines        5176     5140      -36     
  Branches      895      895              
==========================================
- Hits         4975     4936      -39     
- Misses        119      120       +1     
- Partials       82       84       +2
Flag Coverage Δ
centos-linux-7 91.63% <ø> (ø)
centos-linux-8 92.49% <ø> (ø)
centos-linux-9 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 3c9d4c6 to c9587e4 Compare November 25, 2024 16:54
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from c9587e4 to 8dc23b2 Compare December 2, 2024 16:57
@bocekm bocekm added skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests/skip This PR does not require integration tests to be run. kind/infra Related to infrastructure changes labels Dec 9, 2024
@has-bot
Copy link
Member

has-bot commented Dec 9, 2024

This PR does not require integration tests to be run.

Comment generated by an automation.

@bocekm
Copy link
Member

bocekm commented Dec 9, 2024

Before it's merged, c2r code needs to have % string formatting replaced with format() https://docs.astral.sh/ruff/rules/printf-string-formatting/.

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 8dc23b2 to 060f4f6 Compare December 9, 2024 16:55
@Venefilyn
Copy link
Member

Venefilyn commented Dec 9, 2024

Before it's merged, c2r code needs to have % string formatting replaced with format() docs.astral.sh/ruff/rules/printf-string-formatting.

We could force merge it now and have follow-up PR?

@bocekm
Copy link
Member

bocekm commented Dec 9, 2024 •
edited
Loading

We certainly can, but creating the PR ahead of time, merging that first and then rebasing this PR seems cleaner to me as it would not create a window during which pre-commit CI fails for anyone rebasing to main.

@Venefilyn Venefilyn mentioned this pull request Dec 11, 2024
Open
@Venefilyn
Copy link
Member

Venefilyn commented Dec 11, 2024

We certainly can, but creating the PR ahead of time, merging that first and then rebasing this PR seems cleaner to me as it would not create a window during which pre-commit CI fails for anyone rebasing to main.

Didn't check anything but put something up at least in #1448

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 060f4f6 to 736e58e Compare December 16, 2024 16:54
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 742de89 to f8a45cf Compare December 30, 2024 16:50
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from e75fceb to 1375e7f Compare January 13, 2025 16:56
@pre-commit-ci pre-commit-ci bot requested review from a team as code owners January 13, 2025 16:56
@pre-commit-ci pre-commit-ci bot requested a review from danmyway January 13, 2025 16:56
Venefilyn
Venefilyn reviewed Jan 20, 2025
View reviewed changes
tests/integration/test_helpers/satellite.py
Comment on lines -32 to 36
def _curl_the_satellite_script(self, curl_command):
assert (
self.shell(f"{curl_command} -o {self._sat_script_location}", silent=True).returncode == 0
), "Failed to curl the satellite script to the machine."
assert self.shell(f"{curl_command} -o {self._sat_script_location}", silent=True).returncode == 0, (
"Failed to curl the satellite script to the machine."
)

Copy link
Member

@Venefilyn Venefilyn Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 01243f4 to ee2fa43 Compare January 20, 2025 16:53
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from ea54f4c to 4a9c142 Compare January 27, 2025 16:56
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 6cb38c7 to 9c37f55 Compare February 10, 2025 16:57
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 09ab8c1 to 9fd693d Compare February 24, 2025 16:47
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 6d96ef3 to b4644da Compare May 19, 2025 16:46
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 73ebf4d to d092f39 Compare May 26, 2025 16:47
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from d60be88 to 939f94b Compare June 9, 2025 16:48
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 360b986 to 7c0b62d Compare June 30, 2025 16:46
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from c09595e to 3abf747 Compare July 14, 2025 16:46
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 23df522 to 4ed886c Compare July 28, 2025 16:49
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 5955b43 to 7454b9a Compare August 4, 2025 16:55
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 77250a7 to e37164a Compare August 18, 2025 16:51
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 4955efc to b401a90 Compare August 25, 2025 16:50
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from d90bc5c to 7750f49 Compare September 8, 2025 16:51
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 384ced4 to 7201382 Compare September 15, 2025 16:52
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 11b34e0 to 6d26057 Compare September 29, 2025 16:50
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from ebb89c7 to e258907 Compare October 13, 2025 16:53
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 0f21974 to 59fdf5d Compare October 20, 2025 16:52
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 866f4f1 to b3c9803 Compare October 27, 2025 16:52
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 5eeaff8 to 297cf17 Compare November 3, 2025 16:56
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from f2b008d to 51ffa18 Compare November 17, 2025 16:54
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from cc44bc0 to ab705ee Compare November 24, 2025 16:56
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
7477143 
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.7.3 → v0.14.7](astral-sh/ruff-pre-commit@v0.7.3...v0.14.7)
- [github.com/pre-commit/pre-commit-hooks: v5.0.0 → v6.0.0](pre-commit/pre-commit-hooks@v5.0.0...v6.0.0)
- [github.com/teemtee/tmt.git: 1.38.0 → 1.62.1](https://github.com/teemtee/tmt.git/compare/1.38.0...1.62.1)
- [github.com/packit/pre-commit-hooks: v1.2.0 → v1.3.0](packit/pre-commit-hooks@v1.2.0...v1.3.0)
- [github.com/gitleaks/gitleaks: v8.21.2 → v8.30.0](gitleaks/gitleaks@v8.21.2...v8.30.0)
- [github.com/jendrikseipp/vulture: v2.13 → v2.14](jendrikseipp/vulture@v2.13...v2.14)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 91a173e to 7477143 Compare December 1, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Venefilyn Venefilyn Venefilyn approved these changes

@bocekm bocekm bocekm approved these changes

@danmyway danmyway Awaiting requested review from danmyway danmyway is a code owner automatically assigned from oamg/conversions-qe

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

kind/infra Related to infrastructure changes skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests/skip This PR does not require integration tests to be run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@has-bot @bocekm @Venefilyn